Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change code link colors? #170

Open
sjspielman opened this issue Oct 20, 2023 · 3 comments
Open

Change code link colors? #170

sjspielman opened this issue Oct 20, 2023 · 3 comments

Comments

@sjspielman
Copy link
Member

I noticed that inline code formatted text looks the same whether it's a link or just regular text. For example, these will have the same styling in readthedocs -

Maybe we need to incorporate some different styling so in-line code formatted text that is a link clearly appears as a link?

@sjspielman
Copy link
Member Author

sjspielman commented Jan 16, 2024

I wonder if this something worth including in one of the upcoming releases. @dvenprasad, do you have any thoughts here on a) whether this is worth pursuing, b) how soon it* makes sense to pursue this, and c) if (a) is true, what color 🎨 ?

@dvenprasad
Copy link
Member

Users not being able to recognize links when enclose in backticks came up in evals of scpca-nf and downstream analyses but Github generously made that distinction for us.

So yes, if it is a simple and easy fix, we can include it in one of the upcoming docs releases. The link color should be blue (#003595). If it isn't possible to specify the color, the generic internet blue for links also works.

@sjspielman
Copy link
Member Author

sjspielman commented Feb 1, 2024

I confess, with my limited css skills, I thought popping something as simple as

.pre a {
  color: #003595;
}

into style.css would work, but alas. Then I did more silly things like all combinations of

a .reference-external .docutils-literal-notranslate .pre {
  color: #003595;
}

(inspired by this line of source code, just to test things out....)

<a class="reference external" href="https://alevin-fry.readthedocs.io/en/latest/"><code class="docutils literal notranslate"><span class="pre">alevin-fry</span></code></a>

So, surprising no one, I have come to the conclusion that someone who actually knows css should take this over!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants