Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Module testing GHA path updates #676

Closed
sjspielman opened this issue Jul 31, 2024 · 1 comment · Fixed by #748
Closed

Discussion: Module testing GHA path updates #676

sjspielman opened this issue Jul 31, 2024 · 1 comment · Fixed by #748
Assignees
Labels
OpenScPCA admin Issue for an OpenScPCA maintainer

Comments

@sjspielman
Copy link
Member

Two items I've noticed about triggers for module testing GHAs, using this for example:

paths:
- analyses/doublet-detection/**
- .github/workflows/run_doublet-detection.yml

  1. I wondered if we want to update path to exclude Dockerfile? The reason for this is if a Dockerfile has been updated, then the environment is not up-to-date for the analysis to run successfully. That said, this only is true if the GHA is actually using the Docker image. So, perhaps this something we'd do internally: When we update GHAs to pull Docker images, we'd also update it to exclude the Dockerfile path as a trigger. (GHA path docs)
  2. At once point, I had added .github/workflows/run_doublet-detection.yml into the paths field. We might consider doing this more generally and/or adding it to the template module testing GHA
@sjspielman sjspielman added the OpenScPCA admin Issue for an OpenScPCA maintainer label Jul 31, 2024
@jashapiro
Copy link
Member

Let's do this, yes!

Note that we will need to revert the change noted in #746 (comment)

As for the Docker question, if changes are only in the Dockerfile/.dockerignore, then there is not much point in rerunning the workflow whether or not the action is using Docker, so we may as well do that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenScPCA admin Issue for an OpenScPCA maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants