You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wondered if we want to update path to excludeDockerfile? The reason for this is if a Dockerfile has been updated, then the environment is not up-to-date for the analysis to run successfully. That said, this only is true if the GHA is actually using the Docker image. So, perhaps this something we'd do internally: When we update GHAs to pull Docker images, we'd also update it to exclude the Dockerfile path as a trigger. (GHA path docs)
At once point, I had added .github/workflows/run_doublet-detection.yml into the paths field. We might consider doing this more generally and/or adding it to the template module testing GHA
The text was updated successfully, but these errors were encountered:
Note that we will need to revert the change noted in #746 (comment)
As for the Docker question, if changes are only in the Dockerfile/.dockerignore, then there is not much point in rerunning the workflow whether or not the action is using Docker, so we may as well do that too.
Two items I've noticed about triggers for module testing GHAs, using this for example:
OpenScPCA-analysis/.github/workflows/run_doublet-detection.yml
Lines 25 to 27 in c6a0a24
path
to excludeDockerfile
? The reason for this is if a Dockerfile has been updated, then the environment is not up-to-date for the analysis to run successfully. That said, this only is true if the GHA is actually using the Docker image. So, perhaps this something we'd do internally: When we update GHAs to pull Docker images, we'd also update it to exclude the Dockerfile path as a trigger. (GHA path docs).github/workflows/run_doublet-detection.yml
into thepaths
field. We might consider doing this more generally and/or adding it to the template module testing GHAThe text was updated successfully, but these errors were encountered: