Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: .gitignore ignores data/ and thus data was not moved in pr #122 #124

Closed
b0661 opened this issue Oct 7, 2024 · 1 comment · Fixed by #125
Closed

[BUG]: .gitignore ignores data/ and thus data was not moved in pr #122 #124

b0661 opened this issue Oct 7, 2024 · 1 comment · Fixed by #125
Labels
bug Something isn't working

Comments

@b0661
Copy link
Collaborator

b0661 commented Oct 7, 2024

Describe the issue:

Due to .gitignore directive files in data/ are ignored. Thus data was not moved to correct location by pr #122.

Reproduceable code example:

N/A

Error message:

File load_profiles.npz missing

Version information:

PR #122
@b0661 b0661 added the bug Something isn't working label Oct 7, 2024
@b0661 b0661 mentioned this issue Oct 7, 2024
Merged
@b0661
Copy link
Collaborator Author

b0661 commented Oct 8, 2024

After merging #135 this bug becomes obvious as it is now detected by the test. Please merge #125 to make the tests pass again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Adapt data to package directory structure b0661/EOS
1 participant
@b0661