Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: the future of kahla #721

Open
xxyzz opened this issue Oct 25, 2019 · 4 comments
Open

Discussion: the future of kahla #721

xxyzz opened this issue Oct 25, 2019 · 4 comments
Labels
Others Under consideration Under consideration if to fix

Comments

@xxyzz
Copy link
Contributor

xxyzz commented Oct 25, 2019

Below are my suggestion, order represents priority. Fell free to express your opinion.

  • Writing test before implement.
  • Replace web socket with other protocols. It's hard to tell which temp message is sent or not in the current design.
  • Support end-to-end encryption. Almost all the apps in this page offering E2E encryption.
  • Use a CSS framework.
  • Discard electron or create a separate project. Electron app shouldn't be a 100MB broken web page.
  • Refactoring with react.
  • Support voice and video call.
  • Provide .onion domain.
  • Replace non-FOSS
@Anduin2017
Copy link
Member

Anduin2017 commented Oct 25, 2019

Wow. That gonna be hard work.

Have you considered web assembly?

And what is .onion domain?

If we discard electron, how shall we face desktop environments whose browser is f**king 360 browser or QQ browser?

@Anduin2017
Copy link
Member

Anduin2017 commented Oct 25, 2019

@xxyzz

As for refactoring to react,

You need to understand that we have spent years on Anuglar. And Angular works fine with electron, PWA, service-worker, web push and typescript.

But for react: none of our team once learnt it before. All of us need to re-learn everything about it. And try to implement PWA on it. That gonna be very hard work.

Giving up our thousands of lines of code and refactor it with another technology costs us something. You need to provider two lists before really decide it:

  • What we will get if we refactor.
  • What dose it cost if we refactor.

And then we will try to balance if it is worth to spend it on the second list and get benefits from the first list.

@hv0905
Copy link
Member

hv0905 commented Oct 25, 2019

For now, I think we should focus on reflacting existing code and add features (voice call + E2E)

@Anduin2017
Copy link
Member

@Xiangrui2019 why edit it?

@Anduin2017 Anduin2017 reopened this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Others Under consideration Under consideration if to fix
Projects
None yet
Development

No branches or pull requests

10 participants