remove the use of waitForBlock function from z:acceptance tests
#10
Assignees
Comments
Jorge-Lopes
changed the title
waitForBlock function from z:acceptance testswaitForBlock function from z:acceptance tests
|
This issue is still awaiting clarification and more input |
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Sep 30, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Sep 30, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Sep 30, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 5, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 5, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 8, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 9, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 16, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 16, 2024
Refs: Agoric/BytePitchPartnerEng#10 fix: formatting fixes and change requests fix(sync-tools): apply new linting rules and fix rebase conflicts Refs: Agoric#10238
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 22, 2024
Refs: Agoric/BytePitchPartnerEng#10 fix: formatting fixes and change requests fix(sync-tools): apply new linting rules and fix rebase conflicts Refs: Agoric#10238
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Oct 22, 2024
refs: Agoric/BytePitchPartnerEng#10 refs: Agoric/agoric-3-proposals#181 ## Description Currently the way to make sure a transaction sent to agoric chain has been executed is to use a method from `@agoric/synthetic-chain` called `waitForBlock` which stops the execution flow of a given ava test until N number of blocks are produced. This is not as deterministic as we'd like it to be but so far it worked fine. However, it could still end up in a race condition in some extreme cases. In this PR we introduce a set of tools to sync operations carried out in a test. Currently this PR supports operations like; * Making sure a core-eval resulted successfully deploying a contract * Making sure a core-eval successfully sent zoe invitations to committee members for governance * Making sure an account is successfully funded with vbank assets like IST, BLD etc. * Making sure an offer resulted successfully See Agoric/agoric-3-proposals#181 for further discussion. ### Security Considerations This is merely a testing tool, so no security considerations. ### Scaling Considerations This is merely a testing tool, so no scaling considerations. ### Documentation Considerations If this ends up getting in to `@agoric/synthetic-chain` then we might need more extensive explanation of what we do. But for now, I don't think any documentation is needed. ### Testing Considerations Have confirmed that this works fine with existing a3p tests locally but to keep the scope tighter I will update those tests one this PR lands. The coverage of the unit tests in `sync-tools.test.js` seems fine but I'm open to suggestions, of course.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Effort Estimate: 4h (0.5 days)
Effort Required:
Dependencies: To address this task, we propose to first start by extending the @agoric/synthetic-chain package to export a method like
makeRetryUntilConditionor a similar function.See this comment for more context.
Objective: Using waitForBlock() can lead to unexpected behavior, so we intend to refactor tests to utilize a new method for waiting on conditions instead.
Tasks
waitForBlockagoric-3-proposals#181The text was updated successfully, but these errors were encountered: