Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ternary grace=None, pitched=None flags with boolean flags #1123

Open
3 tasks
trevorbaca opened this issue Aug 22, 2019 · 0 comments
Open
3 tasks

Replace ternary grace=None, pitched=None flags with boolean flags #1123

trevorbaca opened this issue Aug 22, 2019 · 0 comments
Assignees
@trevorbaca
Labels
refactor

Comments

@trevorbaca
Copy link
Member

trevorbaca commented Aug 22, 2019 •
edited
Loading

The grace=None, nontrivial=None, pitched=None flags are the only ternary flags in the system.

  • Replace grace=None with exclude_grace=False, exclude_nongrace=False.
  • Replace nontrivial=None with exclude_nontrivial=False, exclude_trivial=False.
  • Replace pitched=None with exclude_pitched=False, exclude_nonpitched=False.

The refactor sites are abjad.iterate.*(), abjad.select.*().
@trevorbaca trevorbaca self-assigned this Aug 22, 2019
@trevorbaca trevorbaca mentioned this issue Oct 12, 2022
Open
@trevorbaca trevorbaca added this to the 4.0 milestone Oct 12, 2022
@trevorbaca trevorbaca changed the title Replace ternary grace=None, pitched=None flags with boolean flags Replace ternary grace=None, pitched=None flags with boolean flags Apr 20, 2023
@trevorbaca trevorbaca removed this from the 4.0 milestone Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trevorbaca trevorbaca

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevorbaca