From bf7dc80032ffec2e241bc345126fb6fffff2f047 Mon Sep 17 00:00:00 2001 From: S McDowall Date: Sat, 28 Jan 2023 13:53:52 -0500 Subject: [PATCH] Update CONTRIBUTING.md Updated how the PR should be branched against, etc. --- CONTRIBUTING.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ed3c0d92..63d4ddcb 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,9 +9,9 @@ The easiest way to get involved is to create a [new issue](https://github.com/Ab If you plan to submit a PR please do the following: - Fork the repository -- Create a feature branch from the **develop** branch! +- Create a feature branch from the **master** branch! - Following the coding guidlines below -- Submit the PR against the **develop** branch. +- Submit the PR against the **master** branch. - Update both Material and Cupertino code if applicable ## General coding guidlines @@ -23,6 +23,8 @@ If you'd like to add a feature or fix a bug, we're more than happy to accept pul - Code is free of lint errors - Format your code with `dartfmt` - Write helpful documentation +- Write new tests that cover your code base changes +- Make sure all current tests pass - If you would like to make a bigger / fundamental change to the codebase, please file a lightweight example PR / issue. ## Before Uploading