Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record the analyte for each procedure #40

Open
meganrwong opened this issue Mar 24, 2023 · 4 comments
Open

record the analyte for each procedure #40

meganrwong opened this issue Mar 24, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@meganrwong
Copy link
Contributor

meganrwong commented Mar 24, 2023

relates to w3c/sdw#35

Could we please get Nel to check the analytes that each procedure measures - they are recorded in the excel template for data mapping as a draft.

If we just type in first, then we'll get on to finding ChEBI URIs if they are available

:) thanks!

@ljgregory

@dr-shorthair
Copy link
Member

Also see w3c/sdw-sosa-ssn#42

@meganrwong meganrwong mentioned this issue Sep 28, 2023
Closed
@meganrwong
Copy link
Contributor Author

meganrwong commented Sep 28, 2023

We modeled this out in Excel that is now with chemists for review, using NERC model as basis https://github.com/nvs-vocabs/P01

We had two use cases here/view on an observable property

  • one was interested in 'extractable phosphorus' being the object of interest with one identifier ( ANSIS implementation) (eg 'extractable phosphorus' 'pseudo-total x' 'soluble y'
    This is being used in current ANSIS implementation and is with chemists to review

  • The other use case was interested in the actual analyte being measured with chem symbol measured' (psedo-total for example being more to do with the method)
    So, the chemists are adding these against the procedures

Once chemists' is done we can see how w3c/sdw-sosa-ssn#42 can help us relate the observable property/analyte to the procedures that could be used to measure them

@meganrwong
Copy link
Contributor Author

can use - https://www.ebi.ac.uk/ols/search?q=iron&groupField=iri&start=0&ontology=chebi
or if not there, may be be in IUPAC. I can see you can dois, but I can't see how to get them for individual elements / compounds (they are within the definitions of their roles /activities (eg NO3 is under the definition of 'oxidant')

@meganrwong meganrwong added enhancement New feature or request wontfix This will not be worked on labels Mar 22, 2024
@meganrwong meganrwong removed the wontfix This will not be worked on label Mar 22, 2024
@meganrwong
Copy link
Contributor Author

Source Green Book stewards (ASPAC chemists) did not review the analytes drafted in excel. Where the properties are represented (as drafted in excel and scripted into phase 1 ANSIS JSON implementation has been flagged as work required in phase 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants