feat: 3주차 필수 과제 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjdrjs00
requested review from
Hyobeen-Park,
jihyunniiii,
MinseoSONG and
beom84
Hyobeen-Park
approved these changes
Nov 3, 2024
MinseoSONG
reviewed
Nov 3, 2024
Comment on lines
8
to
22
| @Composable | ||
| fun Modifier.showSnackbarEffect( | ||
| message: String, | ||
| snackbarHostState: SnackbarHostState, | ||
| onMessageShown: () -> Unit = {} | ||
| ) = this.then( | ||
| Modifier.apply { | ||
| if (message.isNotEmpty()) { | ||
| LaunchedEffect(snackbarHostState) { | ||
| snackbarHostState.showSnackbar(message) | ||
| onMessageShown() | ||
| } | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
어 .. 이 코드에 대해 설명해주실 수 있을까요 ?? Modifier.으로 시작하는 함수를 처음봐서요 !
MinseoSONG
approved these changes
Nov 4, 2024
l2hyunwoo
suggested changes
Nov 4, 2024
Comment on lines
15
to
20
| if (message.isNotEmpty()) { | ||
| LaunchedEffect(snackbarHostState) { | ||
| snackbarHostState.showSnackbar(message) | ||
| onMessageShown() | ||
| } | ||
| } |
There was a problem hiding this comment.
이 확장함수는 어떤 것을 의도하려고 하는지 가늠이 안되네요....message를 변경시킬 때 showSnackbar를 호출하는건지, snackbarHostState가 변경될때 showSnackbar를 호출하는건지, 그리고 onMessageShown은 왜 있는건지 다 명확한 이유가 없는 것 같습니다...한번 함수 설계를 다시 해보시는 것을 권장드립니다.
이게 Modifier에 체이닝 되어야 하는것인지, 그렇다면 왜 그래야 하는지부터 생각해보면 좋을 것 같아요.
비즈니스 로직 계층 domain에서 형식 검증에 대한 책임을 가지도록 분리함
제거 사유: - 명확한 의도 전달성 부족 - 확장성 부족
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
1. 공통 컴포넌트 찾기
whiteText()/grayText()2. 뷰 스케치 및 각 화면 컴포넌트화
3. UI 로직 설계
4. 공통되는 로직 확장함수화
Uncompleted Tasks 😅
To Reviewers 📢