rq draft #23
Merged
rq draft #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good. :) Can you add some details what this PR is about? |
|
Bernie says that he wants to try writing the test for rq and its grad by himself so I asked him to create a PR and I can easily look at this. |
|
Excellent - now we have something to test. Hopefully it's the code that's buggy and not the test :) |
|
@beaman33 please confirm it works as expected - and after that I think we can merge to the 1D experimental branch for now. |
|
After we merge this PR to |
|
CI failing due to method overwrite - will fix that in the new clean up in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jerry says I need to know how to do PR
Major updates from this branch: