Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add um2netcdf entry point(s) #82

Closed
truth-quark opened this issue Aug 21, 2024 · 2 comments
Closed

Add um2netcdf entry point(s) #82

truth-quark opened this issue Aug 21, 2024 · 2 comments
Assignees

Comments

@truth-quark
Copy link
Collaborator

truth-quark commented Aug 21, 2024

For simplicity, this issue is for um2netcdf entry points, separate to the ESM1.5 conversion driver entry points.

Tasks for adding entry points for um2netcdf are:

  • Move cmd line parsing & process() call into a new main() function
  • Update conda (?) config to allow direct calls to um2netcdf (via console-scripts)
  • Add CI test to verify simple command(s) can be called from the env e.g. un2netcdf --help

Other general thoughts:

  • Moving the parsing & process() call to functions provides an interface for testing
    • As of mid Aug 2024, cmd line parsing cannot be tested as it's in __main__
  • Adding main() provides a top level function
    • this facilitates splitting process() into workflow sub functions under main()
    • helps simplify testing with reduced need for complex test setups & mocking
    • new workflows can be composed from the components (do future ESM versions need custom um2nc workflows?)
@truth-quark
Copy link
Collaborator Author

Resolved by #86.

@truth-quark truth-quark self-assigned this Aug 22, 2024
@truth-quark
Copy link
Collaborator Author

This relates to #81 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant