Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Repro CI Experiment Checksum structure with Config Repo structure #75

Open
CodeGat opened this issue Oct 9, 2024 · 0 comments
Open
Assignees
Labels
priority:medium type:bug type:infra Dealing with CI/CD Pipelines

Comments

@CodeGat
Copy link
Collaborator

CodeGat commented Oct 9, 2024

The Problem

Currently, the struture of the checksums in a repro test experiment running on Gadi are the following:

$EXPERIMENT_LOCATION/
└── checksum/
    ├── historical-*hr-checksum.json
    └── test_report.xml

And the structure of the checksums in the repo are:

.
└── testing/
    └── checksum/
        ├── historical-*hr-checksum.json
        └── test_report.xml

In which, in the CI, we special-case the logic for creating the intermediate testing directory in the repo. This also creates problems for the inputs.additional-artifact-content-paths, which are, confusingly, in the correct place at both the experiment level and the repo level, which means they both have to be handled differently.

The Solution

Unify the checksum directories so that both the experiment and repo reflect the following structure:

$EXPERIMENT_LOCATION_OR_REPO_ROOT/
└── testing/
    └── checksum/
        ├── historical-*hr-checksum.json
        └── test_report.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium type:bug type:infra Dealing with CI/CD Pipelines
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant