Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove commit-check Job and Replace With Conditional Job Execution #69

Open
CodeGat opened this issue Oct 2, 2024 · 0 comments
Open
Assignees
Labels

Comments

@CodeGat
Copy link
Collaborator

CodeGat commented Oct 2, 2024

We currently have a commit-check job that gets the authour of the current head_ref. This is used by future jobs so that we don't run repro (or indeed other checks) if they were created by vars.GH_ACTIONS_BOT_GIT_USER_NAME.

This can be simplified, and make the job diagram more palatable, by just using conditional job execution on the repro-ci job. For example, instead of if: needs.commit-check.outputs.authourship != vars.GH_ACTIONS_BOT_GIT_USER_NAME, you can use something like if: github.event.pull_request.head.user.name != vars.GH_ACTIONS_BOT_GIT_USER_NAME.

@CodeGat CodeGat self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant