Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge common check-checksum job into test-repro.yml #76

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Oct 17, 2024

We've been amassing a series of jobs that run after repro-ci that all do the same thing: download the testing artifact, parsing the test data, and returning the result. This has become so common that it should be a part of test-repro.yml itself.

In this PR:

  • test-repro.yml: Move check-checksum into workflow
  • config-schedule-2-start.yml: Move check-checksum out
  • config-pr-1-ci.yml: Move check-checksum out
  • config-comment-test.yml: Move check-checksum out

Closes #68

@CodeGat CodeGat self-assigned this Oct 17, 2024
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

@tmcadam tmcadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good to centralise the common functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate check-checksum into test-repro.yml
3 participants