Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

access-om2 qa checks: Remove option for different forcing keywords #6

Open
aidanheerdegen opened this issue Apr 9, 2024 · 0 comments

Comments

@aidanheerdegen
Copy link
Member

We currently allow any of the following forcing mode keywords

'forcing mode': {'repeat-year', 'ryf', 'repeat-decade', 'rdf', 'interannual', 'iaf'}

It is just confusing and leads to a lack of consistency.

Either we should remove the ryf, rdf and iaf options, or insist on both for each forcing mode, and make each set mutually exclusive.

e.g. something like so

'forcing mode': {{'repeat-year', 'ryf'}, 
                 {'repeat-decade', 'rdf'},
                 {'interannual', 'iaf'}}

But it would require rewriting the logic of that test.

@jo-basevi jo-basevi transferred this issue from ACCESS-NRI/access-om2-configs Apr 29, 2024
@jo-basevi jo-basevi changed the title Remove option for different forcing keywords access-om2 qa checks: Remove option for different forcing keywords Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant