Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read target and Spack version from a config file #165

Open
CodeGat opened this issue Jun 17, 2024 · 0 comments
Open

Read target and Spack version from a config file #165

CodeGat opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
priority:medium A medium priority issue - has some impact on functionality type:enhancement improvements to code but not new features

Comments

@CodeGat
Copy link
Member

CodeGat commented Jun 17, 2024

In #164 we are removing many unneeded ENV variables. $ENV_SPACK_ARCH is the only one referenced outside the build stage:

spack change --match-spec ${{ env.PACKAGE_NAME }} ${{ env.PACKAGE_NAME }}@git.$GH_REF%${{ matrix.compiler.COMPILER_NAME }}@${{ matrix.compiler.COMPILER_VERSION }} arch=$ENV_SPACK_ARCH

This is being changed in e39edcd to target, but we still need to keep track of it. @harshula noted that we should put it as a section in config/compilers.json as well.

Remove the ENV and instead propagate config/compilers.jsons .target to model-1-build.yml and other workflows.

From #164 (comment)

@CodeGat CodeGat self-assigned this Jun 17, 2024
@CodeGat CodeGat added priority:medium A medium priority issue - has some impact on functionality type:enhancement improvements to code but not new features labels Jun 17, 2024
@harshula harshula changed the title Read target from config/compilers.json Read target and Spack version from a config file Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium A medium priority issue - has some impact on functionality type:enhancement improvements to code but not new features
Projects
None yet
Development

No branches or pull requests

1 participant