Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename model-1-build.ymls 'generate lockfile' step #105

Open
CodeGat opened this issue Sep 27, 2023 · 0 comments
Open

Rename model-1-build.ymls 'generate lockfile' step #105

CodeGat opened this issue Sep 27, 2023 · 0 comments
Labels
priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality type:enhancement improvements to code but not new features

Comments

@CodeGat
Copy link
Member

CodeGat commented Sep 27, 2023

We are technically not 'generating' a lockfile here, just renaming it for upload. Make it a bit more explicit.

https://github.com/ACCESS-NRI/build-ci/blob/main/.github/workflows/model-1-build.yml#L99-L102

References a suggestion in #100 (namely #100 (comment))

@CodeGat CodeGat added type:feature New feature or request priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality labels Sep 27, 2023
@CodeGat CodeGat added task type:enhancement improvements to code but not new features and removed type:feature New feature or request task labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality type:enhancement improvements to code but not new features
Projects
None yet
Development

No branches or pull requests

1 participant