Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure WOMBATlite in 1deg_jra55do_ryf_wombatlite #47

Conversation

dougiesquire
Copy link
Collaborator

@dougiesquire dougiesquire commented Mar 27, 2024

This PR sets up the 1deg_jra55do_ryf_wombatlite configuration to run with the new generic tracer implementation of WOMBATlite.

@dougiesquire dougiesquire marked this pull request as draft March 27, 2024 21:58
@dougiesquire dougiesquire changed the title 1deg_jra55do_ryf_wombat 1deg_jra55do_ryf_wombatlite Apr 30, 2024
@dougiesquire dougiesquire self-assigned this May 2, 2024
@dougiesquire dougiesquire force-pushed the 1deg_jra55do_ryf_wombat branch 4 times, most recently from 63bb428 to 752f556 Compare May 21, 2024 23:37
@dougiesquire dougiesquire force-pushed the 1deg_jra55do_ryf_wombat branch 2 times, most recently from 450a564 to 0c9258b Compare July 17, 2024 23:07
@dougiesquire dougiesquire changed the base branch from 1deg_jra55do_ryf to 1deg_jra55do_ryf_wombatlite August 21, 2024 04:19
@dougiesquire dougiesquire marked this pull request as ready for review August 21, 2024 05:33
@dougiesquire dougiesquire force-pushed the 1deg_jra55do_ryf_wombat branch 2 times, most recently from a11b965 to 690904a Compare August 21, 2024 05:35
@minghangli-uni
Copy link

I tried to run it but ended up with errors,

1619178 WARNING from PE     1: drtsafe: root not bracketed
1619179
1619180
1619181 WARNING from PE     1: drtsafe: root not bracketed
1619182
1619183
1619184 FATAL from PE    26: NaN in input field of reproducing_EFP_sum(_2d).
1619185
1619186
1619187 FATAL from PE    10: NaN in input field of reproducing_EFP_sum(_2d).

Also I've seen many warning messages, such as

     27 WARNING from PE     0: Previous msg:Z_INIT_ALE_REMAPPING = True     !   [Boolean] default = False
     28
     29
     30 WARNING from PE     0: New message :Z_INIT_ALE_REMAPPING = True     !   [Boolean] default = True

I am not sure about it. Are we expecting these warnings for WOMBAT?

@dougiesquire
Copy link
Collaborator Author

dougiesquire commented Aug 21, 2024

Are we expecting these warnings for WOMBAT?

No, these are not expected. These warnings are introduced after @aekiss's changes in #94 to increase DT_THERM=6*DT. To run WOMBAT with THERMO_SPANS_COUPLING requires a configuration change and I haven't tested this yet.

I think we should revert the changes from #94. They haven't been tested. Also, why was the coupling timestep halved? @aekiss and @minghangli-uni are you okay for me to revert this commit?

UPDATE: I've submitted a PR to revert the commit.

@dougiesquire dougiesquire changed the title 1deg_jra55do_ryf_wombatlite Configure WOMBATlite in 1deg_jra55do_ryf_wombatlite Aug 21, 2024
@minghangli-uni
Copy link

Thanks @dougiesquire. Halving the coupling timestep is to avoid the unused buoyancy fluxes crash. See COSIMA/access-om3#195 and NCAR/MOM6#290

@dougiesquire
Copy link
Collaborator Author

dougiesquire commented Aug 21, 2024

Halving the coupling timestep is to avoid the unused buoyancy fluxes crash.

Thanks @minghangli-uni. I think it would be better to understand and resolve the issue if we can. Halving the coupling time step will unnecessarily additional overhead.

@minghangli-uni
Copy link

I will revisit this issue COSIMA/access-om3#195.

Copy link

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dougiesquire. I successfully ran it for a month and am comfortable with merging it. But one thing to note that without spanning dt_therm, there are still some warnings, such as this one:

225 WARNING from PE     0: Previous msg:Z_INIT_ALE_REMAPPING = True     !   [Boolean] default = False
226
227
228 WARNING from PE     0: New message :Z_INIT_ALE_REMAPPING = True     !   [Boolean] default = True

@dougiesquire
Copy link
Collaborator Author

Thanks @dougiesquire. I successfully ran it for a month and am comfortable with merging it. But one thing to note that without spanning dt_therm, there are still some warnings, such as this one:

225 WARNING from PE     0: Previous msg:Z_INIT_ALE_REMAPPING = True     !   [Boolean] default = False
226
227
228 WARNING from PE     0: New message :Z_INIT_ALE_REMAPPING = True     !   [Boolean] default = True> ```

Sorry yes I forgot to mention - this is because the default for this parameter is different in different modules. These should be resolved in the future but I think the warnings are okay for now.

@dougiesquire dougiesquire merged commit e1d1e8d into ACCESS-NRI:1deg_jra55do_ryf_wombatlite Aug 22, 2024
@dougiesquire dougiesquire deleted the 1deg_jra55do_ryf_wombat branch August 22, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants