Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to nri-spack #124

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

anton-seaice
Copy link
Contributor

Move to nri-spack build. This is using the same access-om3 code and dependencies as the cosima-spack, although some build settings are different (e.g. the 'target' attribute). Its possible the performance is slightly different with this build.

The build still uses https://github.com/COSIMA/access-om3 for model components

Copy link

@minghangli-uni minghangli-uni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My queue seems endless... but I successfully ran it for a model day. Thanks @anton-seaice !

@anton-seaice
Copy link
Contributor Author

Thanks - yeah, hopefully its just end of quarter congestion

@anton-seaice anton-seaice merged commit aab0665 into dev-1deg_jra55do_ryf Sep 25, 2024
@anton-seaice anton-seaice deleted the dev-1deg_jra55do_ryf-iss194 branch September 25, 2024 23:07
@minghangli-uni
Copy link

Will this change need to be applied to the other configs?

@anton-seaice
Copy link
Contributor Author

!cherry-pick 689d08c aab0665 into dev-1deg_jra55do_iaf

@anton-seaice
Copy link
Contributor Author

@micaeljtoliveira We have a new error - maybe its related to move this repo to the ACCESS-NRI org ..

  * [new branch]      cherry_pick_from_pr124_into_dev-1deg_jra55do_iaf -> cherry_pick_from_pr124_into_dev-1deg_jra55do_iaf
branch 'cherry_pick_from_pr124_into_dev-1deg_jra55do_iaf' set up to track 'origin/cherry_pick_from_pr124_into_dev-1deg_jra55do_iaf'.
pull request create failed: GraphQL: GitHub Actions is not permitted to create or approve pull requests (createPullRequest)
Error: Process completed with exit code 1.

see

https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/11045531809/job/30683320883

also ping @CodeGat for your thoughts :)

@CodeGat
Copy link
Contributor

CodeGat commented Sep 26, 2024

It seems that the job has permissions.pull-requests:write so I'm not certain...

@micaeljtoliveira
Copy link
Contributor

micaeljtoliveira commented Sep 26, 2024

Someone with appropriate permissions needs to go to the project settings and allow Actions to create PRs (see here for more details).

@CodeGat
Copy link
Contributor

CodeGat commented Sep 26, 2024

Ah, okay. That setting is greyed out for me and I'm an admin. I'll see if it's disallowed at the org level.

Copy link

!cherry-pick 689d08c aab0665 into dev-1deg_jra55do_iaf

Automatic cherry-pick failed. It seems there are previous unfinished attempts to cherry-pick commits from this PR to the following branch(es):

If the current cherry-pick attempt is for a different set of commits, make sure that the previous attempts are fully merged and that the corresponding branches have been deleted.

@anton-seaice
Copy link
Contributor Author

!cherry-pick 689d08c aab0665 into dev-1deg_jra55do_ryf_wombatlite

Copy link

Automatic Git cherry-picking of commit(s) 689d08c aab0665 into dev-1deg_jra55do_ryf_wombatlite was successful.

The new pull request can be reviewed and approved here.

@anton-seaice
Copy link
Contributor Author

!cherry-pick 689d08c aab0665 into dev-025deg_jra55do_ryf

Copy link

Automatic Git cherry-picking of commit(s) 689d08c aab0665 into dev-025deg_jra55do_ryf was successful.

The new pull request can be reviewed and approved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants