Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML Support #12

Open
A248 opened this issue Jan 11, 2021 · 2 comments
Open

TOML Support #12

A248 opened this issue Jan 11, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@A248
Copy link
Owner

A248 commented Jan 11, 2021

Implement Toml support using tomlj as well as a custom toml writer.

It should not be too difficult to create a toml writer.

See #2

@A248 A248 added the enhancement New feature or request label Jan 11, 2021
@A248 A248 added this to the 1.2.0 milestone Jan 11, 2021
@A248
Copy link
Owner Author

A248 commented Jan 19, 2021

@jwpjrdev Here is the state of toml support:

  • Someone opened a PR to tomlj which adds a writer: Toml writer tomlj/tomlj#19. As such, that's likely what we'll be using to write toml. I do not think this writer supports comments. Likely, I will see about PR-ing basic comment-writing support to tomlj.
  • tomlj uses a filename-based module name, but there is a (very short) PR I made to fix that.
  • The toml-support branch is partially complete. The only part left is the toml writing.

@jwpjrdev
Copy link

jwpjrdev commented Jan 20, 2021 via email

@A248 A248 added the help wanted Extra attention is needed label Mar 21, 2021
@A248 A248 modified the milestones: 1.2.0, 1.3.0 Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants