Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add multi-architecture support (arm64) #341

Open
2 tasks done
AtomicFS opened this issue Sep 25, 2024 · 0 comments · May be fixed by #343
Open
2 tasks done

add multi-architecture support (arm64) #341

AtomicFS opened this issue Sep 25, 2024 · 0 comments · May be fixed by #343
Assignees
@AtomicFS
Labels
feature New feature or request go Pull requests that update Go code python Pull requests that update Python code

Comments

@AtomicFS
Copy link
Collaborator

AtomicFS commented Sep 25, 2024 •
edited
Loading

It would be nice to add support for other architectures other than x86.

The golang code is already compiled for arm64, i386 and x86_64. And Docker containers do support multi-arch images. Not only that, dagger which we are using supports this too.

  • Add multi-arch support to python code responsible for building the containers
  • Add multi-arch support to golang code
    • this might already be supported by default because of docker / dagger
    • this is handled by dagger / docker when we provide multi-platform containers
@AtomicFS AtomicFS added feature New feature or request go Pull requests that update Go code python Pull requests that update Python code labels Sep 25, 2024
@AtomicFS AtomicFS self-assigned this Sep 25, 2024
@AtomicFS AtomicFS linked a pull request Oct 25, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AtomicFS AtomicFS

Labels
feature New feature or request go Pull requests that update Go code python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docker): make containers multi-arch 9elements/firmware-action
1 participant
@AtomicFS