Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize JSON formatter: unnecessary string conversions #147

Open
3Hren opened this issue Aug 22, 2016 · 0 comments
Open

Optimize JSON formatter: unnecessary string conversions #147

3Hren opened this issue Aug 22, 2016 · 0 comments
Labels
P: normal T: perf V: minor

Comments

@3Hren
Copy link
Owner

3Hren commented Aug 22, 2016 •
edited
Loading

There are some maps with std::string. However an attribute name is a std::string_view, and without c++17 it's required to always convert view into string to perform find operation.

This can be optimized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P: normal T: perf V: minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@3Hren