Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release files consistent across versions #27

Open
Not-A-Normal-Robot opened this issue Nov 5, 2024 · 8 comments
Open

Make release files consistent across versions #27

Not-A-Normal-Robot opened this issue Nov 5, 2024 · 8 comments

Comments

@Not-A-Normal-Robot
Copy link
Member

Currently, the older versions use a different release format (e.g., separate win32 and win64 ZIPs) than the current one (e.g., combined Windows.zip file).
Making the release file naming consistent between versions allows things like user-made scripts and Boxedmino to function with less complex logic.

@ImpleLee
Copy link
Contributor

ImpleLee commented Nov 5, 2024

What do you think is the best option to solve this problem?

Current format is specified in CI in this repo, and is (probably) relied on by the techmino CI. I mean, if you choose to change the current format, all the CI code needs updating, and that is a lot of work, and I don't want to accidentally break working code.

On the other hand, maybe it is better to leave the files in the historical releases there, so we can manually compose historical techmino versions if we want.

Maybe one option is to make new "historical" releases? But if by any accident we did not specify one version in any CI (can this happen? I don't know), it will probably be built with the new "historical" releases (or pre-releases?)...

@ImpleLee
Copy link
Contributor

ImpleLee commented Nov 5, 2024

I would say the best option to me is to just leave all the files as they are now. In the foreseeable future, the format here probably will not change, so only the previous formats are special, and your code will probably just work with any other future cc update.

@Not-A-Normal-Robot
Copy link
Member Author

There's no need to "create" new releases, we can just edit an old release and re-zip the old release files in the new format. Because apparently GitHub Releases allows you to do that.

@ImpleLee
Copy link
Contributor

ImpleLee commented Nov 5, 2024

There's no need to "create" new releases, we can just edit an old release and re-zip the old release files in the new format. Because apparently GitHub Releases allows you to do that.

I understand. Can this be done without editing old release files? Because I want to leave the original files untouched and only add the new formats.

@ImpleLee
Copy link
Contributor

ImpleLee commented Nov 5, 2024

Maybe their file names do not conflict?

@Not-A-Normal-Robot
Copy link
Member Author

I mean I guess but then users would be confused because there'll be both a Windows.zip, win32.zip, and win64.zip

@ImpleLee
Copy link
Contributor

ImpleLee commented Nov 6, 2024

I mean I guess but then users would be confused because there'll be both a Windows.zip, win32.zip, and win64.zip

Removing historical files is unacceptable to me, especially in this very situation where you want to make historical versions available.

@Not-A-Normal-Robot
Copy link
Member Author

Not-A-Normal-Robot commented Nov 6, 2024

Hmm I think editing releases allow you to edit the description too

So I guess it shouldn't be that hard to add a note saying something along the lines of "the windows.zip one is the same as win32.zip + win64.zip, we made it like that to be consistent with the new release filenames without deleting old ones"

Obviously that isn't the exact note we'll be adding because of other differences like android

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants