Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing sections with divs #241

Open
3 tasks
dmundra opened this issue Jun 16, 2021 · 0 comments
Open
3 tasks

Replacing sections with divs #241

dmundra opened this issue Jun 16, 2021 · 0 comments
Labels
g: initial Issue template needs to be filled out, and/or initiative/timing labels need to be added. i: infrastructure Relating to technology underneath/supporting custom software across TTS

Comments

@dmundra
Copy link
Contributor

dmundra commented Jun 16, 2021

Background Information

We are using the uswds-jekyll theme in a couple of sites that we also testing with Axe and we found that the <section> tags used in the banner, hero, and similar throws up this Axe error:

All page content should be contained by landmarks

Link to the specific Axe rule: https://dequeuniversity.com/rules/axe/4.1/region

Reading up on sections in HTML I think it probably better to use <div> in this case than <section> for those regions. For reference https://css-tricks.com/how-to-section-your-html/#dont-swap-div-for-a-section. Another option could be to wrap all the <section> tags in another section like an aside but that might require more work.

Implementation Steps

  • Replace sections with divs

Acceptance Criteria

  • Run pa11y-ci with axe and confirm 'All page content should be contained by landmarks' error is no longer being reported.
  • Reduce --threshold of pa11y-ci after the above is fixed to reveal errors if they appear in future pull requests.
@dmundra dmundra added the g: initial Issue template needs to be filled out, and/or initiative/timing labels need to be added. label Jun 16, 2021
@afeld afeld added the i: infrastructure Relating to technology underneath/supporting custom software across TTS label Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
g: initial Issue template needs to be filled out, and/or initiative/timing labels need to be added. i: infrastructure Relating to technology underneath/supporting custom software across TTS
Projects
None yet
Development

No branches or pull requests

2 participants