Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS reporting error on dependent library nikic/php-parser, hamcrest/hamcrest-php #251

Open
sfgourav opened this issue Sep 2, 2024 · 1 comment
Labels
Dependencies Items related to Composer dependencies

Comments

@sfgourav
Copy link

sfgourav commented Sep 2, 2024

Bug report

  • Need update of dependent libraries to support php 8.2+

Replication steps

  • If we run phpcs on the repo we see the following errors
    Screenshot 2024-09-02 at 12 30 37 PM
    Screenshot 2024-09-02 at 12 30 21 PM

Expected behavior

  • support for dependent libraries for php8.2+
@nmolham-godaddy
Copy link
Contributor

Thanks @sfgourav for reporting this potential issue with php 8.2. according to composer.lock WP_Mock using the latest release version of hamcrest/hamcrest-php package https://github.com/hamcrest/hamcrest-php/releases/tag/v2.0.1 which it about 4 years old. But as far as I can tell the hex value is still valid, don't you think?

FYI: I found there is an issue already open for that error => hamcrest/hamcrest-php#78

@nmolham-godaddy nmolham-godaddy added the Dependencies Items related to Composer dependencies label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Items related to Composer dependencies
Projects
None yet
Development

No branches or pull requests

2 participants