Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opinionated code quality tools #201

Open
tobeycodes opened this issue Nov 6, 2023 · 2 comments
Open

Add opinionated code quality tools #201

tobeycodes opened this issue Nov 6, 2023 · 2 comments

Comments

@tobeycodes
Copy link
Member

I think we should consider adding some more PHP tools for code quality

  • PHP Unit - I recently setup a project and added 10up/wp_mock and Pest PHP.
  • PHPMD - Similar to PHP Stan we can add a baseline to ignore all the existing errors
  • Rector - Auto refactor code, this is really good to make sure you keep code up to date and make things like PHP upgrades seamless

All of these tools can be and should be opt in. If you don't run the commands or have a blocking CI job then they just stay silently unused in the repository. We can add documentation and/or commands to remove them for projects that definitely do not want them

@claytoncollie
Copy link
Contributor

+1 for these tools

Linking to the existing PR to implement PHPStan --> #133

@tobeycodes
Copy link
Member Author

@claytoncollie Thanks for sharing the link to that. I am using a modified version of that PR in an existing project and it works quite well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants