Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP warnings due to wrong param type #224

Closed
1 task done
dkotter opened this issue Jul 28, 2023 · 2 comments · Fixed by #261
Closed
1 task done

PHP warnings due to wrong param type #224

dkotter opened this issue Jul 28, 2023 · 2 comments · Fixed by #261
Labels
help wanted type:bug Something isn’t working.
Milestone
2.7.8

Comments

@dkotter
Copy link
Collaborator

dkotter commented Jul 28, 2023

Describe the bug

As reported on WordPress.org, seems there's some situations that can result in PHP warnings. I have not been able to reproduce myself but in looking at the code, I think we can add a couple checks here to easily suppress these warnings.

Steps to Reproduce

See https://wordpress.org/support/topic/error-during-authorization-to-rocketchat/

Screenshots, screen recording, code snippet

No response

Environment information

No response

WordPress information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:bug Something isn’t working. label Jul 28, 2023
@vikrampm1
Copy link

Maybe we can close #220 in favor of this if they're related?

@dkotter
Copy link
Collaborator Author

dkotter commented Jul 31, 2023

Maybe we can close #220 in favor of this if they're related?

No, these are different issues. #220 is about adding PHP version checks whereas this issue is about some users getting PHP warnings

@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Jan 11, 2024
@jeffpaul jeffpaul added this to the Future Release milestone Jan 11, 2024
@jeffpaul jeffpaul moved this from Backlog to To Do in Open Source Practice Jan 17, 2024
BhargavBhandari90 added a commit to BhargavBhandari90/simple-local-avatars that referenced this issue Mar 10, 2024
@BhargavBhandari90
Fix - 10up#224 Avoid php warnings
51b2389
@BhargavBhandari90 BhargavBhandari90 mentioned this issue Mar 10, 2024
Merged
4 tasks
@jeffpaul jeffpaul modified the milestones: Future Release, 2.8.0 Mar 11, 2024
@jeffpaul jeffpaul moved this from To Do to In Review in Open Source Practice Mar 11, 2024
dkotter added a commit that referenced this issue Mar 12, 2024
@dkotter
Merge pull request #261 from BhargavBhandari90/fix/issue-224
3089823 
Fix - #224 Avoid php warnings
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice Mar 12, 2024
@faisal-alvi faisal-alvi modified the milestones: 2.8.0, 2.7.8 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type:bug Something isn’t working.
Projects
Open Source Practice
Archived in project
Milestone
2.7.8
Development

Successfully merging a pull request may close this issue.

Fix - #224 Avoid php warnings BhargavBhandari90/simple-local-avatars
4 participants
@dkotter @jeffpaul @faisal-alvi @vikrampm1