Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voiceover crashes the characters modal #26

Open
samikeijonen opened this issue Aug 26, 2019 · 1 comment
Open

Voiceover crashes the characters modal #26

samikeijonen opened this issue Aug 26, 2019 · 1 comment
Labels
help wanted Extra attention is needed type:accessibility An issue with accessibility. type:bug Something isn't working.

Comments

@samikeijonen
Copy link
Contributor

samikeijonen commented Aug 26, 2019

Describe the bug
When I try to open characters modal using Voiceover in Safari, nothing really happens. It seems that paragraph text kind of even disappear.

Steps to Reproduce

  1. Open Voiceover.
  2. Tab to Special Characters.
  3. Hit Enter.
  4. Characters dialog doesn't open.
  5. It even seems that it messes the up the paragraph I was trying to add the character.

Expected behavior
Should work also with screen readers.

Screenshots
opening with voiceover, nothing happens

Environment information

  • Device: MacBook
  • OS: MacOS 10.14.5
  • Browser and version: Safari 12.1.1.
  • Plugins and version: master and 6.3 Gutenberg
  • Theme and version: Theme scaffold
  • Other installed plugin(s) and version(s):

Additional context

@samikeijonen samikeijonen added the type:bug Something isn't working. label Aug 26, 2019
@adamsilverstein adamsilverstein added the type:accessibility An issue with accessibility. label Aug 26, 2019
@adamsilverstein adamsilverstein added this to the 1.1.0 milestone Aug 26, 2019
@samikeijonen
Copy link
Contributor Author

I was able to replicate this on WP 5.3.2. However, I didn't replicate this when using Gutenberg plugin version 7.3. Since latest from Gutenberg is soonish merging to WP, I don't see this as big issue.

There is still something weird on focus when using keyboard only on Safari. Not related to screen readers.

See GIF below where moving focus with keyboard Shift+Tab and pressing Enter on Special characters, nothing really happens. Modal doesn't open.

focus moving in toolbar

I see this error on console when hitting Enter:

TypeError: null is not an object (evaluating 'e.collapsed')

@jeffpaul jeffpaul added help wanted Extra attention is needed type:bug Something isn't working. and removed type:bug Something isn't working. labels Feb 3, 2020
@dkotter dkotter modified the milestones: 1.0.5, 1.1.0 Jun 24, 2022
@jeffpaul jeffpaul modified the milestones: 1.1.0, Future Release Jun 28, 2022
@cadic cadic self-assigned this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:accessibility An issue with accessibility. type:bug Something isn't working.
Projects
None yet
Development

No branches or pull requests

6 participants