From b7b0de4fc8d5c176fc93904693bde3bb6429b34b Mon Sep 17 00:00:00 2001 From: Adam Silverstein Date: Wed, 4 Sep 2019 22:45:51 -0600 Subject: [PATCH 01/18] fix for ff --- src/insert-special-characters.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/insert-special-characters.js b/src/insert-special-characters.js index ed72de0..cf6b4f1 100644 --- a/src/insert-special-characters.js +++ b/src/insert-special-characters.js @@ -45,9 +45,9 @@ registerFormatType( type, { }; // Pin the Popover to the caret position. - const anchorRect = () => { + const anchorRect = () => { return getRectangleFromRange( anchorRange ); - } ; + }; // Display the character map when it is active. if ( isActive ) { @@ -56,7 +56,7 @@ registerFormatType( type, { {} } getAnchorRect={ anchorRect } From 5119d0b90a7a5f8efd5503a1a19c7e2b574a60d1 Mon Sep 17 00:00:00 2001 From: Helen Hou-Sandi Date: Thu, 5 Sep 2019 12:18:48 -0600 Subject: [PATCH 02/18] Also reference correct asset update action --- .github/workflows/push-asset-readme-update.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/push-asset-readme-update.yml b/.github/workflows/push-asset-readme-update.yml index 64f83d8..7efb691 100644 --- a/.github/workflows/push-asset-readme-update.yml +++ b/.github/workflows/push-asset-readme-update.yml @@ -10,7 +10,7 @@ jobs: steps: - uses: actions/checkout@master - name: WordPress.org plugin asset/readme update - uses: 10up/actions-wordpress/dotorg-plugin-asset-update@master + uses: 10up/action-wordpress-plugin-asset-update@master env: SVN_PASSWORD: ${{ secrets.SVN_PASSWORD }} SVN_USERNAME: ${{ secrets.SVN_USERNAME }} From ed2a4ecfaa3aa7a8572f6641ed8d88b72092ebde Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Thu, 5 Sep 2019 13:34:05 -0500 Subject: [PATCH 03/18] fix credits.md link in readme.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index e07b375..2f9a7f8 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ A complete listing of all notable changes to Insert Special Characters are docum ## Contributing -Please read [CODE_OF_CONDUCT.md](https://github.com/10up/insert-special-characters/blob/develop/CODE_OF_CONDUCT.md) for details on our code of conduct, [CONTRIBUTING.md](https://github.com/10up/insert-special-characters/blob/develop/CONTRIBUTING.md) for details on the process for submitting pull requests to us, and [CREDITS.md](https://github.com/10up/insert-special-characters/blob/develop/CONTRIBUTORS.md) for a listing of maintainers of, contributors to, and libraries used by Insert Special Characters. +Please read [CODE_OF_CONDUCT.md](https://github.com/10up/insert-special-characters/blob/develop/CODE_OF_CONDUCT.md) for details on our code of conduct, [CONTRIBUTING.md](https://github.com/10up/insert-special-characters/blob/develop/CONTRIBUTING.md) for details on the process for submitting pull requests to us, and [CREDITS.md](https://github.com/10up/insert-special-characters/blob/develop/CREDITS.md) for a listing of maintainers of, contributors to, and libraries used by Insert Special Characters. ## Like what you see? From cf16e98022dc6777d1b8abda882df23970234732 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:29:21 -0500 Subject: [PATCH 04/18] prepare v1.0.1 changelog updates --- CHANGELOG.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b3eb151..8d14b55 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,11 +4,16 @@ All notable changes to this project will be documented in this file, per [the Ke ## [Unreleased] - TBD +## [1.0.1] - TBD +### Fixed +- Firefox popover closing immediately after opening the first time (props @adamsilverstein via #41) + ## [1.0.0] - 2019-08-21 ### Added - Initial plugin release 🎉 - Wrap [React Character Map](https://github.com/Dayjo/react-character-map) in a Gutenberg Popover (props @adamsilverstein via #1) - Plugin header and icon images (props @McCallumDillon via #28) -[Unreleased]: https://github.com/10up/insert-special-characters/compare/1.0.0...master +[Unreleased]: https://github.com/10up/insert-special-characters/compare/1.0.1...master +[1.0.1]: https://github.com/10up/insert-special-characters/compare/1.0.0...1.0.1 [1.0.0]: https://github.com/10up/insert-special-characters/releases/tag/1.0.0 From 79d100ab1a09ca5ef48f197920daf748853e2fa5 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:41:13 -0500 Subject: [PATCH 05/18] update release instructions --- CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9aab440..fc3dc60 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -30,9 +30,11 @@ The `develop` branch is the development branch which means it contains the next 1. Starting from `develop`, cut a release branch named `release/X.Y.Z` for your changes. 2. Version bump: Bump the version number in `insert-special-characters.php` and `package.json` if it does not already reflect the version being released. -3. Changelog: Add/update the changelog in `CHANGELOG.md` +3. Changelog: Add/update the changelog in `CHANGELOG.md` and `readme.txt` 4. Check to be sure any new files/paths that are unnecessary in the production version are included in `.distignore`. 5. Merge: Make a non-fast-forward merge from your release branch to `develop` (or merge the pull request), then do the same for `develop` into `master`. `master` contains the stable development version. 6. Push: Push your master branch to GitHub, e.g. `git push origin master`. 7. Git tag: Create a [new release](https://github.com/10up/insert-special-characters/releases/new) as `X.Y.Z` on the `master` branch in GitHub. 8. Deploy to WordPress.org: Head to the [Actions](https://github.com/10up/insert-special-characters/actions) tab in the repo and wait for the Deploy to WordPress.org workflow to finish if it hasn't already. If it doesn't succeed, figure out why and head back to delete the tag and try again. +9. Edit the [X.Y.Y milestone](https://github.com/10up/insert-special-characters/milestone/#) with release date (in the `Due date (optional)` field) and link to GitHub release (in the `Description` field), then close the `X.Y.Z` milestone. +10. If any open issues or PRs which were milestoned for `X.Y.Z` do not make it into the release, update their milestone to `X.Y.Z+1` or `Future Release`. From a650a0ca49c3b44cc3e0d9ffdd3d1540783b4457 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:45:45 -0500 Subject: [PATCH 06/18] Add to changelog in readme.txt --- readme.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/readme.txt b/readme.txt index 1b0a725..b2d48ae 100644 --- a/readme.txt +++ b/readme.txt @@ -35,8 +35,12 @@ Development takes place in the GitHub repository: https://github.com/10up/insert == Changelog == += 1.0.1 = +Fixed +* Firefox popover closing immediately after opening the first time (props @adamsilverstein) + = 1.0.0 = -== Added == +Added * Initial plugin release 🎉 * Wrap [React Character Map](https://github.com/Dayjo/react-character-map) in a Gutenberg Popover (props @adamsilverstein) * Plugin header and icon images (props @dillonmccallum) From 5458381917665961954f3f31fbec89479f747fe2 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:48:03 -0500 Subject: [PATCH 07/18] fix links in readme.txt --- readme.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/readme.txt b/readme.txt index b2d48ae..8b8d777 100644 --- a/readme.txt +++ b/readme.txt @@ -15,13 +15,13 @@ A Special Character inserter for the WordPress block editor (Gutenberg). A Special Character inserter for the WordPress block editor (Gutenberg). Requires PHP 5.6+ and WordPress 5.2+. -Development takes place in the GitHub repository: https://github.com/10up/insert-special-characters. +Development takes place in the [GitHub repository](https://github.com/10up/insert-special-characters). === Technical Notes === * Requires PHP 5.6+. * Requires [WordPress](http://wordpress.org/) 5.2+ -* Issues and Pull requests welcome in the GitHub repository: https://github.com/10up/insert-special-characters. +* Issues and Pull requests welcome in the [GitHub repository](https://github.com/10up/insert-special-characters). == Screenshots == @@ -37,10 +37,10 @@ Development takes place in the GitHub repository: https://github.com/10up/insert = 1.0.1 = Fixed -* Firefox popover closing immediately after opening the first time (props @adamsilverstein) +* Firefox popover closing immediately after opening the first time (props [@adamsilverstein](https://profiles.wordpress.org/adamsilverstein/)) = 1.0.0 = Added * Initial plugin release 🎉 -* Wrap [React Character Map](https://github.com/Dayjo/react-character-map) in a Gutenberg Popover (props @adamsilverstein) -* Plugin header and icon images (props @dillonmccallum) +* Wrap [React Character Map](https://github.com/Dayjo/react-character-map) in a Gutenberg Popover (props [@adamsilverstein](https://profiles.wordpress.org/adamsilverstein/)) +* Plugin header and icon images (props [@dillonmccallum](https://profiles.wordpress.org/dillonmccallum/)) From b784b94074b6f2e6d2f2a1fe0606d0331232aab2 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:50:04 -0500 Subject: [PATCH 08/18] add details to description in readme.txt --- readme.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/readme.txt b/readme.txt index 8b8d777..b7fe017 100644 --- a/readme.txt +++ b/readme.txt @@ -12,8 +12,7 @@ A Special Character inserter for the WordPress block editor (Gutenberg). == Description == -A Special Character inserter for the WordPress block editor (Gutenberg). -Requires PHP 5.6+ and WordPress 5.2+. +Ever wanted to add a special character while working within the WordPress block editor (Gutenberg) and suddenly find yourself longing for the days of the Classic Editor and the Special Character inserter? Well long no more, the Insert Special Characters plugin is here to ease your publishing woes! Development takes place in the [GitHub repository](https://github.com/10up/insert-special-characters). From 03ab46156f5e31dcbebf35dfd11794a8aa154527 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:53:59 -0500 Subject: [PATCH 09/18] add the keyboard shortcut to readme.md --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index e07b375..996dea9 100644 --- a/README.md +++ b/README.md @@ -8,6 +8,8 @@ Ever wanted to add a special character while working within Gutenberg and suddenly find yourself longing for the days of the Classic Editor and the Special Character inserter? Well long no more, the Insert Special Characters plugin is here to ease your publishing woes! +**Note:** you can display the popover via the `ctrl`/`cmd` + `o` keyboard shortcut. + ![Demo of special characters within Gutenberg](assets/insert-special-characters.gif "Example of a special characters in the new WordPress editor") ## Extending From 6732fb5520c2c9e47e59364e441dddd65c64552c Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 11:59:12 -0500 Subject: [PATCH 10/18] add the keyboard shortcut to readme.txt --- readme.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/readme.txt b/readme.txt index 1b0a725..dfa3c77 100644 --- a/readme.txt +++ b/readme.txt @@ -15,6 +15,8 @@ A Special Character inserter for the WordPress block editor (Gutenberg). A Special Character inserter for the WordPress block editor (Gutenberg). Requires PHP 5.6+ and WordPress 5.2+. +**Note:** you can display the popover via the `ctrl`/`cmd` + `o` keyboard shortcut. + Development takes place in the GitHub repository: https://github.com/10up/insert-special-characters. === Technical Notes === From 99bda03f14a97ded2466d95bbbcbdd49ec0e37ee Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:07:28 -0500 Subject: [PATCH 11/18] Merge remote-tracking branch 'origin/develop' into add/shortcut --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 996dea9..849eaa9 100644 --- a/README.md +++ b/README.md @@ -60,7 +60,7 @@ A complete listing of all notable changes to Insert Special Characters are docum ## Contributing -Please read [CODE_OF_CONDUCT.md](https://github.com/10up/insert-special-characters/blob/develop/CODE_OF_CONDUCT.md) for details on our code of conduct, [CONTRIBUTING.md](https://github.com/10up/insert-special-characters/blob/develop/CONTRIBUTING.md) for details on the process for submitting pull requests to us, and [CREDITS.md](https://github.com/10up/insert-special-characters/blob/develop/CONTRIBUTORS.md) for a listing of maintainers of, contributors to, and libraries used by Insert Special Characters. +Please read [CODE_OF_CONDUCT.md](https://github.com/10up/insert-special-characters/blob/develop/CODE_OF_CONDUCT.md) for details on our code of conduct, [CONTRIBUTING.md](https://github.com/10up/insert-special-characters/blob/develop/CONTRIBUTING.md) for details on the process for submitting pull requests to us, and [CREDITS.md](https://github.com/10up/insert-special-characters/blob/develop/CREDITS.md) for a listing of maintainers of, contributors to, and libraries used by Insert Special Characters. ## Like what you see? From 0b86ac9ec45ade6d4cc699438f3ae89ce2a42298 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:10:12 -0500 Subject: [PATCH 12/18] update version number in package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 8426d11..f70749c 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "insert-special-characters", - "version": "1.0.0", + "version": "1.0.1", "description": "", "main": "insert-special-characters.js", "scripts": { From 9d92e5d07fd04a1056eec128ac5480ef47ee83f9 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:14:43 -0500 Subject: [PATCH 13/18] add #44 to changelog.md --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8d14b55..db8531f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file, per [the Ke ## [Unreleased] - TBD ## [1.0.1] - TBD +### Added +- Documentation for keyboard shortcut (props @mrwweb, @jeffpaul via #44) + ### Fixed - Firefox popover closing immediately after opening the first time (props @adamsilverstein via #41) From 861a0aae2cc7460bc4900473c5f553f8f06ac333 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:16:15 -0500 Subject: [PATCH 14/18] add #44 to readme.txt --- readme.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/readme.txt b/readme.txt index b7fe017..2573521 100644 --- a/readme.txt +++ b/readme.txt @@ -35,6 +35,9 @@ Development takes place in the [GitHub repository](https://github.com/10up/inser == Changelog == = 1.0.1 = +Added +* Documentation for keyboard shortcut (props [@mrwweb](https://profiles.wordpress.org/mrwweb/), [@jeffpaul](https://profiles.wordpress.org/jeffpaul/)) + Fixed * Firefox popover closing immediately after opening the first time (props [@adamsilverstein](https://profiles.wordpress.org/adamsilverstein/)) From 660d9228b712762314103948425ce68fd205dec7 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:16:37 -0500 Subject: [PATCH 15/18] added @mrwweb to contributors list in credits.md --- CREDITS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CREDITS.md b/CREDITS.md index 4ddf1aa..236355d 100644 --- a/CREDITS.md +++ b/CREDITS.md @@ -10,7 +10,7 @@ The following individuals are responsible for curating the list of issues, respo Thank you to all the people who have already contributed to this repository via bug reports, code, design, ideas, project management, translation, testing, etc. -[Adam Silverstein (@adamsilverstein)](https://github.com/adamsilverstein), [Helen Hou-Sandi (@helen)](https://github.com/helen), [Jeffrey Paul (@jeffpaul)](https://github.com/jeffpaul) +[Adam Silverstein (@adamsilverstein)](https://github.com/adamsilverstein), [Helen Hou-Sandi (@helen)](https://github.com/helen), [Jeffrey Paul (@jeffpaul)](https://github.com/jeffpaul), [Mark Root-Wiley (@mrwweb)](https://github.com/mrwweb) ## Libraries From 9a5b129a65369817be315b1bd6c5cac4036889b5 Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:18:12 -0500 Subject: [PATCH 16/18] update version number in insert-special-characters.php --- insert-special-characters.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/insert-special-characters.php b/insert-special-characters.php index f3b606c..d7844ff 100644 --- a/insert-special-characters.php +++ b/insert-special-characters.php @@ -3,7 +3,7 @@ * Plugin Name: Insert Special Characters * Plugin URI: https://github.com/10up/insert-special-characters * Description: A Special Character inserter for the WordPress block editor (Gutenberg). - * Version: 1.0.0 + * Version: 1.0.1 * Requires at least: 5.2 * Requires PHP: 5.6 * Author: 10up From a686c08fc8694e810dce7c9677f9913a61020e1c Mon Sep 17 00:00:00 2001 From: Jeffrey Paul Date: Fri, 6 Sep 2019 12:18:49 -0500 Subject: [PATCH 17/18] update version number in readme.txt --- readme.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/readme.txt b/readme.txt index 2573521..7717b47 100644 --- a/readme.txt +++ b/readme.txt @@ -4,7 +4,7 @@ Tags: Special Characters, Character Map, Omega, Gutenberg, Block, block editor Requires at least: 5.2 Tested up to: 5.2 Requires PHP: 5.6 -Stable tag: 1.0.0 +Stable tag: 1.0.1 License: MIT License URI: http://www.gnu.org/licenses/mit.html From fac5d3682d077c9cc18d12a19bed1c812772fcac Mon Sep 17 00:00:00 2001 From: Helen Hou-Sandi Date: Fri, 6 Sep 2019 16:15:47 -0600 Subject: [PATCH 18/18] Apply suggestions from 1.0.1 docs review --- CHANGELOG.md | 4 ++-- CONTRIBUTING.md | 2 +- readme.txt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index db8531f..6b7f5af 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,12 +4,12 @@ All notable changes to this project will be documented in this file, per [the Ke ## [Unreleased] - TBD -## [1.0.1] - TBD +## [1.0.1] - 2019-09-06 ### Added - Documentation for keyboard shortcut (props @mrwweb, @jeffpaul via #44) ### Fixed -- Firefox popover closing immediately after opening the first time (props @adamsilverstein via #41) +- Ensure character map appears as expected in Firefox (props @adamsilverstein via #41) ## [1.0.0] - 2019-08-21 ### Added diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index fc3dc60..8c14a3c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,5 +36,5 @@ The `develop` branch is the development branch which means it contains the next 6. Push: Push your master branch to GitHub, e.g. `git push origin master`. 7. Git tag: Create a [new release](https://github.com/10up/insert-special-characters/releases/new) as `X.Y.Z` on the `master` branch in GitHub. 8. Deploy to WordPress.org: Head to the [Actions](https://github.com/10up/insert-special-characters/actions) tab in the repo and wait for the Deploy to WordPress.org workflow to finish if it hasn't already. If it doesn't succeed, figure out why and head back to delete the tag and try again. -9. Edit the [X.Y.Y milestone](https://github.com/10up/insert-special-characters/milestone/#) with release date (in the `Due date (optional)` field) and link to GitHub release (in the `Description` field), then close the `X.Y.Z` milestone. +9. Edit the [X.Y.Z milestone](https://github.com/10up/insert-special-characters/milestone/#) with release date (in the `Due date (optional)` field) and link to GitHub release (in the `Description` field), then close the `X.Y.Z` milestone. 10. If any open issues or PRs which were milestoned for `X.Y.Z` do not make it into the release, update their milestone to `X.Y.Z+1` or `Future Release`. diff --git a/readme.txt b/readme.txt index ad9df46..1231551 100644 --- a/readme.txt +++ b/readme.txt @@ -41,7 +41,7 @@ Added * Documentation for keyboard shortcut (props [@mrwweb](https://profiles.wordpress.org/mrwweb/), [@jeffpaul](https://profiles.wordpress.org/jeffpaul/)) Fixed -* Firefox popover closing immediately after opening the first time (props [@adamsilverstein](https://profiles.wordpress.org/adamsilverstein/)) +* Ensure character map appears as expected in Firefox (props [@adamsilverstein](https://profiles.wordpress.org/adamsilverstein/)) = 1.0.0 = Added