-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributing blocks with site-specific attributes doesn't work #430
Comments
Hi @cmmarslender, thanks for the feature request! This may be possible with existing filters. I have a few questions about your use case:
How would you know determine the correct term by its id? Are you sure the term already exists on the remote site or might you need to create it? You may need to distribute an object with the term name and slug.
Right! This is an issue with distributing any id referenced content. We currently handle some things automatically, it feels like supporting things like the core image block would be a logical next step (or at the very least documenting how to add support for them). |
Currently pushing and pulling within a multisite network, though ideally there could be some filters exposed for pushing/pulling in either context. In a multisite network, we can compare term on source site and either fetch or create a new term on a destination site.. Would be a bit more challenging in a REST API scenario, but I think exposing the hooks and letting developers deal with implementation details would be amazing - not expecting distributor to do this automatically. |
👍 Seeing the PR now, I missed that earlier. Nice work! I'll leave a comment there. |
There's still a good amount we need to discuss on this and it relates to work we want to tackle in |
Is your enhancement related to a problem? Please describe.
We have a handful of blocks that store data in the json inside the block comment. For example, we might have something like this in the json:
Where leadershipGroup is the id of a term, and we need to filter the block display on the frontend (this block is rendered in php) to only show items from this particular term.
Describe the solution you'd like
Would love to have a filter as blocks are syndicated that allows modification to the json for each block in the content.. In this example, we could update the term ID to reference the proper term on the site we are distributing to.
We run into similar issues with stored media IDs, or really anything that references data specific to the original site in the block data.
The text was updated successfully, but these errors were encountered: