Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: ability to add the plugin’s name in the commit’s message #18

Open
Screenfeed opened this issue Nov 26, 2019 · 6 comments
Open
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Milestone

Comments

@Screenfeed
Copy link

Screenfeed commented Nov 26, 2019

If the SVN user on the repository owns several plugins, it can be hard to follow with the current message:

Update to version $VERSION from GitHub

It could be nice to be able to set an optional environment var containing the plugin’s name, that would display:

$PLUGIN_NAME: update to version $VERSION from GitHub

Alternatively, the plugin slug could be used, or a fully customable message would also work of course.

@Screenfeed Screenfeed added the type:enhancement New feature or request. label Nov 26, 2019
@helen
Copy link
Collaborator

helen commented Mar 4, 2020

Sure, that makes sense. Right now the emails .org sends are prepended with $SLUG: - maybe it makes sense to stick it at the end instead so it's not so redundant? I'm not sure which views people look at most, I use a dedicated user for our plugins rather than my own .org account so I don't really look at its profile/commit history, but I do check for the email alerts.

@jeffpaul jeffpaul added this to the 2.2.0 milestone Jan 5, 2022
@jeffpaul jeffpaul added help wanted Extra attention is needed needs:engineering This requires engineering to resolve. labels Jan 5, 2022
@jeffpaul
Copy link
Member

jeffpaul commented Jan 5, 2022

@Screenfeed per @helen's prior comment, would something like the following work for you?

Update to version $VERSION from GitHub for $PLUGIN_NAME

In tandem with that, where are you viewing these commit messages that would make prepending/appending the plugin name helpful?

@jeffpaul jeffpaul added the needs:feedback This requires reporter feedback to better understand the request. label Jan 5, 2022
@Screenfeed
Copy link
Author

Hello @jeffpaul.

Sure, it would also work.
These messages can be viewed from a repository's plugin page > Development tab > development log.

@jeffpaul
Copy link
Member

@Screenfeed right so if you're browsing to that development log don't you already know the plugin you're looking at? What's the benefit of the plugin name in the commit message then?

@Screenfeed
Copy link
Author

@jeffpaul You're right, this may not be the place I noticed the issue at the time, as I didn't mentioned this information in my first message 🙄
However, I found another place: the profile page. The second entry says "Update to version 4.0.0 from GitHub" but we don't know which plugin has been updated to 4.0.0.

@jeffpaul jeffpaul removed the needs:feedback This requires reporter feedback to better understand the request. label Jan 26, 2022
@richard-muvirimi
Copy link
Contributor

richard-muvirimi commented May 29, 2022

One way to address this is to use the last git commit message as an option, and or alternatively allow the supply of a custom commit message just like the version. Though not in the documentation this can be resolved at run time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants