Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a failure if not all files are added to SVN #100

Open
johnbillion opened this issue Jul 11, 2022 · 1 comment
Open

Trigger a failure if not all files are added to SVN #100

johnbillion opened this issue Jul 11, 2022 · 1 comment
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. type:enhancement New feature or request.

Comments

@johnbillion
Copy link

Is your enhancement related to a problem? Please describe.

There were some files missing from the most recent release of one of my plugins on wordpress.org, despite the .gitignore and .gitattributes configuration being correct. Everything with the build is fine right up to the point where the plugin gets deployed to the plugin directory.

The problem appears to be caused by an existing svn:ignore prop on the plugin directory, which I historically used to prevent files from being deployed before I switched to using this GitHub action. In the most recent release of the plugin I added files which matched the svn:ignore prop, hence when this action added the files they were actually ignored.

Here's the related portion of the script:

svn add . --force > /dev/null

Describe the solution you'd like

It would be great if this action trigger a failure when some files that are present have not been added to svn, to prevent a broken release from being deployed to wordpress.org. I'm not yet sure how this could work.

Additional context

@vikrampm1 vikrampm1 added the type:enhancement New feature or request. label Jul 11, 2022
@jeffpaul jeffpaul added this to the Future Release milestone Jul 12, 2022
@jeffpaul jeffpaul added help wanted Extra attention is needed needs:engineering This requires engineering to resolve. labels Jul 12, 2022
@irshadahmad21
Copy link

+1 for the feature. Fortunately, dry-run: true saved a broken release for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Projects
Status: To Do
Development

No branches or pull requests

4 participants