Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off alerts for "changes not deployed" #36

Open
cadic opened this issue Mar 3, 2022 · 0 comments
Open

Turn off alerts for "changes not deployed" #36

cadic opened this issue Mar 3, 2022 · 0 comments
Labels
help wanted Extra attention is needed needs:discussion This requires discussion to determine next steps. needs:engineering This requires engineering to resolve. type:enhancement New feature or request.

Comments

@cadic
Copy link

cadic commented Mar 3, 2022

Is your enhancement related to a problem? Please describe.

Right now the deploy script returns error code if other files have been modified (which actually not an issue). This triggers email notification about the failed GitHub Action.

if [[ -z $(svn stat) ]]; then
echo "🛑 Nothing to deploy!"
exit 0
# Check if there is more than just the readme.txt modified in trunk
# The leading whitespace in the pattern is important
# so it doesn't match potential readme.txt in subdirectories!
elif svn stat trunk | grep -qvi " trunk/$README_NAME$"; then
echo "🛑 Other files have been modified; changes not deployed"
exit 1
fi

Describe the solution you'd like

Could we exit with code 0 same as "Nothing to deploy" case?

@cadic cadic added the needs:discussion This requires discussion to determine next steps. label Mar 3, 2022
@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted Extra attention is needed needs:engineering This requires engineering to resolve. labels Mar 20, 2023
@jeffpaul jeffpaul added this to the Future Release milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:discussion This requires discussion to determine next steps. needs:engineering This requires engineering to resolve. type:enhancement New feature or request.
Projects
Status: To Do
Development

No branches or pull requests

2 participants