Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt Block API version 3 #3853

Open
1 task done
JakePT opened this issue Mar 4, 2024 · 0 comments
Open
1 task done

Adopt Block API version 3 #3853

JakePT opened this issue Mar 4, 2024 · 0 comments
Labels
enhancement front end Issues mostly related to the Front End like JavaScript/React and CSS. large (16 - 40 hours) low priority needs tests
Milestone
5.2.0

Comments

@JakePT
Copy link
Contributor

JakePT commented Mar 4, 2024

Is your enhancement related to a problem? Please describe.

As of WordPress 6.3:

The post editor will be iframed if all registered blocks have a Block API version 3 or higher and the editor has no classic meta boxes below the blocks. Adding version 3 support means that the block should work inside an iframe, though the block may still be rendered outside the iframe if not all blocks support version 3.

Since ElasticPress' blocks use version 2, it will prevent this behaviour for sites that are otherwise compatible.

The only work involved is increasing the version number and verifying that the blocks work as expected in an iframe. ElasticPress' blocks do not do anything that wouldn't work in an iframe, so I don't anticipate any more work than that.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JakePT JakePT changed the title Adopt API version 3 for blocks Adopt Block API version 3 Mar 4, 2024
@felipeelia felipeelia added this to the 5.1.0 milestone Mar 7, 2024
@JakePT JakePT mentioned this issue Mar 17, 2024
Closed
4 tasks
@JakePT JakePT added front end Issues mostly related to the Front End like JavaScript/React and CSS. and removed good first issue labels Apr 2, 2024
@JakePT JakePT removed their assignment Apr 10, 2024
@JakePT JakePT modified the milestones: 5.1.0, 5.2.0 Apr 10, 2024
@felipeelia felipeelia mentioned this issue May 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement front end Issues mostly related to the Front End like JavaScript/React and CSS. large (16 - 40 hours) low priority needs tests
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Increment block API versions. 10up/ElasticPress
2 participants
@felipeelia @JakePT