diff --git a/.github/workflows/lint-project.yaml b/.github/workflows/lint-project.yaml index afe0884..18bd981 100644 --- a/.github/workflows/lint-project.yaml +++ b/.github/workflows/lint-project.yaml @@ -22,11 +22,18 @@ jobs: use-public-rspm: true - name: Install lintr - run: install.packages("lintr") + run: | + install.packages("lintr") + install.packages("devtools") shell: Rscript {0} + # we must use devtools::load_all to all lintr to not consider + # all of the internal non exported functions as non declared globals + # https://github.com/r-lib/lintr/issues/1137#issuecomment-1127828843 - name: Lint root directory - run: lintr::lint_dir() + run: | + devtools::load_all() + lintr::lint_dir() shell: Rscript {0} env: LINTR_ERROR_ON_LINT: true diff --git a/tests/testthat/test-hdf5.R b/tests/testthat/test-hdf5.R index 8d03081..0c6ca29 100644 --- a/tests/testthat/test-hdf5.R +++ b/tests/testthat/test-hdf5.R @@ -46,9 +46,9 @@ test_that("can create hdf5", { expect_equal(hdf5r::readDataSet(tool), "loupeR") extra <- hdf5r::openGroup(metadata, "extra") - loupeR_seurat_version <- hdf5r::openLocation(extra, "loupeR_seurat_version") - val <- hdf5r::readDataSet(loupeR_seurat_version) - expect(!is.null(hdf5r::readDataSet(loupeR_seurat_version)), "extra field is missing") + louper_seurat_version <- hdf5r::openLocation(extra, "loupeR_seurat_version") + val <- hdf5r::readDataSet(louper_seurat_version) + expect(!is.null(hdf5r::readDataSet(louper_seurat_version)), "extra field is missing") }) test_that("can create hdf5 custom feature ids", {