Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the MASM implementation of the basic wallet to be reused in the user's account code #337

Open
greenhat opened this issue Oct 8, 2024 · 0 comments
Milestone

Comments

@greenhat
Copy link
Contributor

greenhat commented Oct 8, 2024

The MASM implementation is defined in https://github.com/0xPolygonMiden/miden-base/blob/6f541003f3250a779dafa18572ca9e7f8739ffad/miden-lib/asm/miden/contracts/wallets/basic.masm#L1-L111

The naive approach would be to expose them in miden-sdk crate as we do with tx kernel functions and stdlib. The functions are written with the expectation of being called. Although I don't see anything in their implementation that prevents them to be execed we plan to introduce strict rules encoded in the function attributes so this approach(execing) might break in the future.

@greenhat greenhat changed the title Expose the MASM implementation of the basic wallet to be callable in the user's account code Expose the MASM implementation of the basic wallet to be reused in the user's account code Oct 8, 2024
@greenhat greenhat added this to the Beta 1 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant