Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust toolchain version should be set only once #256

Open
greenhat opened this issue Jul 23, 2024 · 1 comment
Open

Rust toolchain version should be set only once #256

greenhat opened this issue Jul 23, 2024 · 1 comment

Comments

@greenhat
Copy link
Contributor

Motivation

Now we have rust toolchain version specified in the rust-toolchain.toml file and in the CARGO_MAKE_TOOLCHAIN env var in ci.yml, which is not ideal. We should set the version only once in rust-toolchain.toml file.

Notes

The newer rust-toolchain.toml format is not supported by actions-rs GA. It only supports the old rust-toolchain format. Plus, the action-rs is not maintained anymore see. So we need to migrate to something else.

@bobbinth
Copy link
Contributor

In other repos (e.g., here) we've moved away from using actions-rs in favor of the methodology used by rust-analyzer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants