Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(rig-lancedb): Improve instructions and example #107

Open
2 tasks
cvauclair opened this issue Nov 14, 2024 · 0 comments
Open
2 tasks

docs(rig-lancedb): Improve instructions and example #107

cvauclair opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
docs Improvements or additions to documentation

Comments

@cvauclair
Copy link
Contributor

The rig-lancedb documentation could be improved with the following:

  • Document that lancedb requires the user to have installed protoc on their machine (the lancedb library will not compile otherwise) and add instructions on how to install it for a couple of popular systems.
  • In the examples, when the table is created, add a check to see if the table already exists. The current examples will fail if run twice since the table creation step will error with a "table already exists" error.
@cvauclair cvauclair added the docs Improvements or additions to documentation label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants